On Mon, 18 Feb 2019 at 16:19, Ben Skeggs skeggsb@gmail.com wrote:
Hey Dave,
Various fixes/cleanups, along with initial support for SVM features utilising HMM address-space mirroring and device memory migration. There's a lot more work to do in these areas, both in terms of features and efficiency, but these can slowly trickle in later down the track.
a) nouveau_svmm_init calls nvif_vmm_init inside a BUG_ON - no don't ever call BUG_ON from a user facing ioctl, especially one that is available on render nodes. WARN_ON maybe, even then just return to userspace.
b) doesn't build without CONFIG_HMM or CONFIG_HMM_MIRROR or some combo of those,
I assume we'd like to keep it building without selecting HMM. So I'm guessing some ifdeffing might be needed, and also some APIs not advertised.
Dave.