Re: [PATCH:libdrm] include <sys/sysmacros.h> directly for major() and minor()

On 07/ 8/15 09:19 AM, Emil Velikov wrote:

Hi Alan

On 7 July 2015 at 01:45, Alan Coopersmith alan.coopersmith@oracle.com wrote:

...

Linux seems to pick this up via another header, but Solaris needs it explictly included, or we get undefined symbol errors for major & minor.

A slightly pedandic suggestion: Can we use sys/types.h + sys/mkdev.h as the manpage suggests. We already do so in xf86drm.c

Sure - I'd thought sysmacros.h was mentioned in a manpage, but can't find that now. It builds fine with those instead, so v2 patch follows.