On Tue, Nov 27, 2018 at 09:56:46PM -0800, Doug Anderson wrote:
Hi,
On Mon, Nov 26, 2018 at 3:12 PM Matthias Kaehlcke mka@chromium.org wrote:
Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate.
In the case of the 14nm PHY I think it's OK that you break compatibility with old device tree files (as this patch does) since the 14nm support was added sorta recently and "git grep" shows no users in linuxnext. You should note that you're breaking compatibility with old DTS files in the commit message here so that if someone crawls out of the woodwork it will be easy for them to understand what happened.
ok, I'll add the note
pll_14nm->vco_ref_clk = devm_clk_get(&pdev->dev, "ref");if (IS_ERR(pll_14nm->vco_ref_clk)) {ret = PTR_ERR(pll_14nm->vco_ref_clk);if (ret != EPROBE_DEFER)Shouldn't this check against -EPROBE_DEFER, not against EPROBE_DEFER? It's negative. Presumably this same feedback needs to be applied to the whole patch series.
You are right, will fix it throughout the series, thanks!
Other than that this looks good to me and you can feel free to add my Reviewed-by tag FWIW.
Great, thanks for the review!
Matthias