Re: [PATCH 3/3] drm/panel: add panel driver for Elida KD35T133 panels

On 2/23/20 4:07 PM, Heiko Stuebner wrote:

+static int kd35t133_unprepare(struct drm_panel *panel) +{

• struct kd35t133 *ctx = panel_to_kd35t133(panel);
• struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
• int ret;
• if (!ctx->prepared)

• return 0;
  

• ret = mipi_dsi_dcs_set_display_off(dsi);
• if (ret < 0)

• DRM_DEV_ERROR(ctx->dev, "failed to set display off: %d\n",
  

• 	      ret);
  

• mipi_dsi_dcs_enter_sleep_mode(dsi);
• if (ret < 0) {

• DRM_DEV_ERROR(ctx->dev, "failed to enter sleep mode: %d\n",
  

• 	      ret);
  

It looks like you forgot to assign the return value from mipi_dsi_dcs_enter_sleep_mode() to ret.

• return ret;
  

• }
• regulator_disable(ctx->iovcc);
• regulator_disable(ctx->vdd);
• ctx->prepared = false;
• return 0;

+}