Re: [PATCH] drm/mediatek: dsi: Use IRQF_TRIGGER_NONE for dsi irq trigger type

+ Chun-Kuang, Philipp:

This mail has been sent to dri devel and linux mediatek, but why it does not exist in mail lists?

Regards, CK

On Thu, 2020-12-24 at 17:54 +0800, Huijuan Xie wrote:

The interrupt trigger is already set by OF. When do devm_request_irq() in driver, please use IRQF_TRIGGER_NONE and don't specify trigger type again.

Signed-off-by: Huijuan Xie huijuan.xie@mediatek.com

drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 4a188a9..1d62489 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1128,9 +1128,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) goto err_unregister_host; }

• irq_set_status_flags(irq_num, IRQ_TYPE_LEVEL_LOW); ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,

• 	       IRQF_TRIGGER_LOW, dev_name(&pdev->dev), dsi);
  

• 	       IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
  

  if (ret) { dev_err(&pdev->dev, "failed to request mediatek dsi irq\n"); goto err_unregister_host;