On Thu, Nov 6, 2014 at 1:13 PM, Daniel Vetter daniel@ffwll.ch wrote:
On Thu, Nov 06, 2014 at 12:43:34PM -0500, Sean Paul wrote:
On Sun, Nov 02, 2014 at 02:19:27PM +0100, Daniel Vetter wrote:
- state->acquire_ctx = drm_modeset_legacy_acquire_ctx(crtc);
+retry:
- crtc_state = drm_atomic_get_crtc_state(state, crtc);
- if (IS_ERR(crtc_state)) {
- ret = PTR_ERR(crtc_state);
- if (ret == -EDEADLK)
- goto backoff;
- else
- goto fail;
This function would benefit from the error cleanup you did in the previous patch (ie, doing the -EDEADLK check in fail and punting to backoff there).
v6 in in this subthread has that already. Can you please check that this one's good?
Yep, looks good.
Sean
Thanks, Daniel
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx