Re: [PATCH 1/5] drm/vgem: virtual GEM provider

On Thu, 9 Feb 2012 00:19:27 +0100, Ben Widawsky ben@bwidawsk.net wrote:

From: Adam Jackson ajax@redhat.com +static void vgem_gem_free_object(struct drm_gem_object *obj) +{

• if (obj->map_list.map)

• drm_gem_free_mmap_offset(obj);
  

• drm_gem_object_release(obj);

+}

drm_gem_free_mmap_offset() should be pushed down into drm_gem_object_release(). Out of the 6 distinct users of drm_gem_object_release(), 3 call drm_gem_free_mmap_offset() just prior and gma500 forgets to.

I do accept that it is a separate patch though ;-) -Chris