Re: [PATCH v5 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP

On Fri, Mar 19, 2021 at 10:38:29AM +0100, Parshuram Thombare wrote:

Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding.

Signed-off-by: Parshuram Thombare pthombar@cadence.com

.../display/bridge/cdns,mhdp8546.yaml | 34 ++++++++++++------- 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml index 63427878715e..d571f4bb6b16 100644 --- a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8546.yaml @@ -17,8 +17,8 @@ properties: - ti,j721e-mhdp8546

reg:

• minItems: 1
• maxItems: 2

• minItems: 2
• maxItems: 3

1 entry was valid and now it is not? That's not a compatible change and needs an explanation at a minimum.

 items:
   - description:
       Register block of mhdptx apb registers up to PHY mapped area (AUX_CONFIG_P).

@@ -26,13 +26,20 @@ properties: included in the associated PHY. - description: Register block for DSS_EDP0_INTG_CFG_VP registers in case of TI J7 SoCs.

•  - description:
  

•      Register block of mhdptx sapb registers.
  
  

  reg-names:

• minItems: 1
• maxItems: 2
• items:

•  - const: mhdptx
  

•  - const: j721e-intg
  

• minItems: 2

• maxItems: 3

• oneOf:

•  - items:
  

•      - const: mhdptx
  

•      - const: j721e-intg
  

•      - const: mhdptx-sapb
  

•  - items:
  

•      - const: mhdptx
  

•      - const: mhdptx-sapb
  
  

  clocks: maxItems: 1

@@ -98,15 +105,15 @@ allOf: then: properties: reg:

•      minItems: 2
  

•      minItems: 3
     reg-names:
  

•      minItems: 2
  

•      minItems: 3
  

  else: properties: reg:

•      maxItems: 1
  

•      maxItems: 2
     reg-names:
  

•      maxItems: 1
  

•      maxItems: 2
  
  

required:

• compatible

@@ -129,8 +136,9 @@ examples:

     mhdp: dp-bridge@f0fb000000 {
         compatible = "cdns,mhdp8546";

•        reg = <0xf0 0xfb000000 0x0 0x1000000>;
  

•        reg-names = "mhdptx";
  

•        reg = <0xf0 0xfb000000 0x0 0x1000000>,
  

•              <0x0 0x4f48000 0x0 0x74>;
  

•        reg-names = "mhdptx", "mhdptx-sapb";
         clocks = <&mhdp_clock>;
         phys = <&dp_phy>;
         phy-names = "dpphy";
  

-- 2.25.1