Hi Maxime,
Thank you for the patch.
On Tue, Jan 11, 2022 at 12:06:35PM +0100, Maxime Ripard wrote:
Following the previous patch, let's introduce a generic panel-lvds binding that documents the panels that don't have any particular constraint documented.
Reviewed-by: Rob Herring robh@kernel.org Signed-off-by: Maxime Ripard maxime@cerno.tech
Changes from v2:
- Added a MAINTAINERS entry
Changes from v1:
- Added missing compatible
- Fixed lint
.../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml new file mode 100644 index 000000000000..fcc50db6a812 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Generic LVDS Display Panel Device Tree Bindings
+maintainers:
- Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com
- Thierry Reding thierry.reding@gmail.com
+allOf:
- $ref: panel-common.yaml#
- $ref: /schemas/display/lvds.yaml/#
+select:
- properties:
- compatible:
contains:const: panel-lvds- not:
- properties:
compatible:contains:enum:- advantech,idk-1110wr- advantech,idk-2121wr- innolux,ee101ia-01d- mitsubishi,aa104xd12- mitsubishi,aa121td01- sgd,gktw70sdae4se
I still don't like this :-( Couldn't we instead do
select: properties: compatible: contains: enum: - auo,b101ew05 - tbs,a711-panel
?
- required:
- compatible
+properties:
- compatible:
- items:
- enum:- auo,b101ew05- tbs,a711-panel- const: panel-lvds+unevaluatedProperties: false
+required:
- compatible
- data-mapping
- width-mm
- height-mm
- panel-timing
- port
+... diff --git a/MAINTAINERS b/MAINTAINERS index 368072da0a05..02001455949e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6080,6 +6080,7 @@ T: git git://anongit.freedesktop.org/drm/drm-misc S: Maintained F: drivers/gpu/drm/panel/panel-lvds.c F: Documentation/devicetree/bindings/display/lvds.yaml +F: Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
DRM DRIVER FOR MANTIX MLAF057WE51 PANELS M: Guido Günther agx@sigxcpu.org