Hi Kevin.
On Tue, Jul 28, 2020 at 06:07:56PM +0800, Kevin Tang wrote:
From: Kevin Tang kevin.tang@unisoc.com
DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface.
Cc: Orson Zhai orsonzhai@gmail.com Cc: Chunyan Zhang zhang.lyra@gmail.com Signed-off-by: Kevin Tang kevin.tang@unisoc.com
.../devicetree/bindings/display/sprd/dpu.yaml | 82 ++++++++++++++++++++++
Could we name it after the compatible "sharkl3-dpu.yaml"?
1 file changed, 82 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/sprd/dpu.yaml
diff --git a/Documentation/devicetree/bindings/display/sprd/dpu.yaml b/Documentation/devicetree/bindings/display/sprd/dpu.yaml new file mode 100644 index 0000000..54ba9b6f --- /dev/null +++ b/Documentation/devicetree/bindings/display/sprd/dpu.yaml @@ -0,0 +1,82 @@ +# SPDX-License-Identifier: GPL-2.0
Can this be: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sprd/dpu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Unisoc SoC Display Processor Unit (DPU)
+maintainers:
- Mark Rutland mark.rutland@arm.com
+description: |
- DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs
- which transfers the image data from a video memory buffer to an internal
- LCD interface.
+properties:
- compatible:
- const: sprd,sharkl3-dpu
- reg:
- maxItems: 1
- description:
Physical base address and length of the DPU registers set- interrupts:
- maxItems: 1
- description:
The interrupt signal from DPU- clocks:
- minItems: 2
- clock-names:
- items:
- const: clk_src_128m- const: clk_src_384m- power-domains:
- description: A phandle to DPU power domain node.
maxItems: 1
- iommus:
- description: A phandle to DPU iommu node.
maxItems: 1
- port:
- type: object
- description:
A port node with endpoint definitions as defined inDocumentation/devicetree/bindings/media/video-interfaces.txt.That port should be the output endpoint, usually output tothe associated DSI.+required:
- compatible
- reg
- interrupts
- clocks
- clock-names
- port
+additionalProperties: false
+examples:
- |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- #include <dt-bindings/clock/sprd,sc9860-clk.h>
- dpu: dpu@0x63000000 {
compatible = "sprd,sharkl3-dpu";reg = <0x0 0x63000000 0x0 0x1000>;interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>;clock-names = "clk_src_128m","clk_src_384m";clocks = <&pll CLK_TWPLL_128M>,<&pll CLK_TWPLL_384M>;dpu_port: port {dpu_out: endpoint {remote-endpoint = <&dsi_in>;};};- };
Be consistent in indent. Now it is a mix of 6 and 8 spaces. (My preference is 4 spaces, but 2,4,6,8 are all OK)
End the file with and end statement like this: <empty line> ...
-- 2.7.4
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel