On Tuesday, October 17, 2017 4:09 AM, Jeffy Chen wrote:
From: Tomasz Figa tfiga@chromium.org
The driver that instantiates the bridge should own the drvdata, as all driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also owned by its driver struct. Moreover, storing two different pointer types in driver data depending on driver initialization status is barely a good practice and in fact has led to many bugs in this driver.
Let's clean up this mess and change Analogix entry points to simply accept some opaque struct pointer, adjusting their users at the same time to avoid breaking the compilation.
Signed-off-by: Tomasz Figa tfiga@chromium.org Signed-off-by: Jeffy Chen jeffy.chen@rock-chips.com Reviewed-by: Andrzej Hajda a.hajda@samsung.com
Acked-by: Jingoo Han jingoohan1@gmail.com
Best regards, Jingoo Han
Changes in v3: None Changes in v2: None
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++--------
drivers/gpu/drm/exynos/exynos_dp.c | 26 ++++++----- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 47
+++++++++++-------
-- include/drm/bridge/analogix_dp.h | 19 ++++---- 4 files changed, 73 insertions(+), 69 deletions(-)