On Thu, Jul 12, 2018 at 10:35:08AM +0200, Daniel Vetter wrote:
On Thu, Jul 12, 2018 at 10:08:18AM +0200, Maxime Ripard wrote:
When commit af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") was merged, the error handling path of the of_property_match_string was changed to take into account the fact that the returned value of that function wasn't an error pointer but an error code.
Unfortunately, this introduced a warning since the now returned value is an integer, while the sun8i_tcon_top_register_gate function should return an error pointer.
Fix that by calling ERR_PTR.
Cc: Jernej Skrabec jernej.skrabec@siol.net Cc: Chen-Yu Tsai wens@csie.org Fixes: af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") Reported-by: kbuild test robot lkp@intel.com Reported-by: Stephen Rothwell sfr@canb.auug.org.au Signed-off-by: Maxime Ripard maxime.ripard@bootlin.com
Matches at least the seamntics of the other returns afaics.
Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
Applied, thanks! Maxime