Re: [PATCH 1/4] drm/format-helper: Implement drm_fb_swab() with per-line helpers

Hello Thomas,

On 4/27/22 16:14, Thomas Zimmermann wrote:

Replace the inner loop of drm_fb_swab() with helper functions that swap the bytes in each pixel. This will allow to share the outer loop with other conversion helpers.

Signed-off-by: Thomas Zimmermann tzimmermann@suse.de

Reviewed-by: Javier Martinez Canillas javierm@redhat.com

I've a meta question though.

Something that I never fully understood in the conversion helpers is if there is some convention about the name of the parameters. Since it seems that in some places we use dbuf, sbuf but in others we use src and dst, and so forth.

If is just that the naming haven't been used consistently, maybe this rework (or a follow-up) could be an opportunity to add consistency in that regard.