28 May
2020
28 May
'20
1:48 p.m.
Hi all,
I realise this has landed, so a small FYI comment.
On Sat, 9 May 2020 at 15:16, Noralf Trønnes noralf@tronnes.org wrote:
+int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect) +{
if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty)
Hmm cannot think of a good reason why anyone would call this with !buffer || !buffer->fb? Might be a good idea to WARN in those cases - otherwise the user is given false sense to security.
Looking at the upcoming user (drm/gud) it already has both - so it's perfectly safe.
-Emil