Re: [PATCH] nouveau: need to handle failed allocation

On Thu, Jan 28, 2016 at 7:09 PM, Insu Yun wuninsu@gmail.com wrote:

drm_property_create_range can be failed in memory pressure. So, it needs to be handled.

Signed-off-by: Insu Yun wuninsu@gmail.com

drivers/gpu/drm/nouveau/nouveau_display.c | 6 ++++++ 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index 24be27d..26b4902 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -443,6 +443,12 @@ nouveau_display_create_properties(struct drm_device *dev) /* -100..+100 */ disp->color_vibrance_property = drm_property_create_range(dev, 0, "color vibrance", 0, 200);

•   if (!disp->underscan_hborder_property ||
  

•                   !disp->underscan_vborder_property ||
  

•                   !disp->vibrant_hue_property ||
  

•                   !disp->color_vibrance_property)
  

•           return;
  

Aren't we at the end of the function anyways?

}

int

1.9.1