On Thu, 19 May 2022 at 00:36, Kuogee Hsieh quic_khsieh@quicinc.com wrote:
This patch add regulator_set_load() before enable regulator at eDP phy driver.
Signed-off-by: Kuogee Hsieh quic_khsieh@quicinc.com
drivers/phy/qualcomm/phy-qcom-edp.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index cacd32f..fbe0be0 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -87,14 +87,20 @@ struct qcom_edp {
struct clk_bulk_data clks[2]; struct regulator_bulk_data supplies[2];
int enable_load[2];};
static int qcom_edp_phy_init(struct phy *phy) { struct qcom_edp *edp = phy_get_drvdata(phy); int ret;
int num_consumers = ARRAY_SIZE(edp->supplies);
No need to. ARRAY_SIZE is compile-time calculated.
int i;
ret = regulator_bulk_enable(ARRAY_SIZE(edp->supplies), edp->supplies);
for (i = num_consumers - 1; i >= 0; --i)regulator_set_load(edp->supplies[i].consumer, edp->enable_load[i]);
Please. Change this to the ascending order or provide a good description why it's done the other way. Your pointer to regulator_bulk_enable() is not valid, as it processes arrays in the ascending order.
ret = regulator_bulk_enable(num_consumers, edp->supplies); if (ret) return ret;@@ -635,6 +641,8 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
edp->supplies[0].supply = "vdda-phy"; edp->supplies[1].supply = "vdda-pll";
edp->enable_load[0] = 21800; /* load for 1.2 V vdda-phy supply */edp->enable_load[1] = 36000; /* load for 1.2 V vdda-pll supply */
Isn't vdda-pll 0.9V? On sm8250 I see VDD_A_USB0_SS_DP_1P2 and VDD_A_USB0_SS_DP_CORE (which is 0.9V).
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(edp->supplies), edp->supplies); if (ret) return ret;-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project