31 May
2016
31 May
'16
1:09 p.m.
On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote:
Why store it in the fb and not eg. the plane state?
Well, drm_plane_state is allocated by drm_atomic_helper_update_plane.
When sticking the hotspot into the the plane state we have to add hot_x and hot_y parameters to drm_plane_funcs->update_plane() and cause quite some churn all over the drm tree.
Or create a separate code path for cursor updates which uses a special drm_atomic_helper_update_plane version, which doesn't look very attractive too due to code duplication.
Sticking it into the drm_framebuffer instead looks like a reasonable alternative.
I'm open to better suggestions.
cheers, Gerd