On Fri, Mar 29, 2019 at 8:12 PM Sean Paul sean@poorly.run wrote:
On Fri, Mar 29, 2019 at 08:02:17PM +0100, Heiko Stübner wrote:
Am Freitag, 29. März 2019, 20:00:10 CET schrieb Sean Paul:
On Fri, Mar 29, 2019 at 07:51:51PM +0100, Heiko Stübner wrote:
Hi,
Am Dienstag, 26. März 2019, 21:44:56 CET schrieb Sean Paul:
From: Sean Paul seanpaul@chromium.org
Instead of rolling our own implementation for tracking when PSR should be [in]active, use the new self refresh helpers to do the heavy lifting.
I only got patches 3-5 and had to pull 1+2 from patchwork, the following applies to the whole series though.
While my Kevin display does still generally work with these 5 patches applied functionality has regressed somehow.
Environment is a standard Debian with framebuffer console and sddm login manager.
Ahh, this is probably b/c fb_dirty is not triggering PSR exit. I had it working in v1, but removed it in v2 since Daniel suggested we require the fb_dirty helpers. I neglected to add support for the fb_dirty helpers, so fbcon updates won't cause the screen to refresh. I'll add the helpers in v3 and make sure I test it out with fbcon.
Thanks for reporting this!
The cursor-not-blinking case above was X11+modesetting+sddm though, so not directly fbcon-related probably ... 2nd issue?
Yep, definitely could be. If you have the chance, could you collect some DRM_DEBUG_KMS logs for the second issue to see what's going on? My guess is there's a legacy path (update_plane?) that's somehow not triggering psr exit.
fb_dirty helper is also for userspace kms. It's just that you get a nice combo with the helpers that also takes care of fbcon (which is a separate path if you don't bother with the dirty helpers but roll your own for everything). And yeah the v2 design is a package, if you handroll your own fb_dirty the magic won't work :-) -Daniel