On Mon, Jun 07, 2010 at 08:32:45PM +0100, David Woodhouse wrote:
The fix is fairly trivial. There's a "big" patch to fs/jffs2/dir.c which accounts for the bulk of my pull request, but if you look harder you'll see it's mostly just a bunch of removing 'return ret;' and adding 'goto fail;' so the error cleanup happens properly.
Al pointed out a second problem at the same time, fixed by commit e72e6497 in the tree I asked you to pull. That involved adding an unlock_new_inode() to the same error paths that the first patch used.
Between the two bugs, I figured it was worth pushing the fixes for 2.6.35.
The third jffs2 patch in that tree is a fix for ctime semantics which is a two-liner. Again not a regression but worth fixing, and -stable fodder.
Al also pointed out that I could use iget_failed(), but I figured that cleanup could wait for 2.6.36.
BTW, if you put jffs2 stuff into a separate queue, I can just pull it (and add iget_failed() conversion on top of that). Not a problem...