Re: [PATCH] drm/msm/dpu: Add newlines to printks

On Thu, 8 Jul 2021 at 09:56, Stephen Boyd swboyd@chromium.org wrote:

Add some missing newlines to the various DRM printks in this file. Noticed while looking at logs. While we're here unbreak quoted strings so grepping them is easier.

Signed-off-by: Stephen Boyd swboyd@chromium.org

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

---

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 1c04b7cce43e..0e9d3fa1544b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -274,20 +274,20 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc,

    /* return EWOULDBLOCK since we know the wait isn't necessary */
    if (phys_enc->enable_state == DPU_ENC_DISABLED) {

•           DRM_ERROR("encoder is disabled id=%u, intr=%d, irq=%d",
  

•           DRM_ERROR("encoder is disabled id=%u, intr=%d, irq=%d\n",
                      DRMID(phys_enc->parent), intr_idx,
                      irq->irq_idx);
            return -EWOULDBLOCK;
    }
  
    if (irq->irq_idx < 0) {
  

•           DRM_DEBUG_KMS("skip irq wait id=%u, intr=%d, irq=%s",
  

•           DRM_DEBUG_KMS("skip irq wait id=%u, intr=%d, irq=%s\n",
                          DRMID(phys_enc->parent), intr_idx,
                          irq->name);
            return 0;
    }
  
  

•   DRM_DEBUG_KMS("id=%u, intr=%d, irq=%d, pp=%d, pending_cnt=%d",
  

•   DRM_DEBUG_KMS("id=%u, intr=%d, irq=%d, pp=%d, pending_cnt=%d\n",
                  DRMID(phys_enc->parent), intr_idx,
                  irq->irq_idx, phys_enc->hw_pp->idx - PINGPONG_0,
                  atomic_read(wait_info->atomic_cnt));
  

@@ -303,8 +303,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc, if (irq_status) { unsigned long flags;

•                   DRM_DEBUG_KMS("irq not triggered id=%u, intr=%d, "
  

•                                 "irq=%d, pp=%d, atomic_cnt=%d",
  

•                   DRM_DEBUG_KMS("irq not triggered id=%u, intr=%d, irq=%d, pp=%d, atomic_cnt=%d\n",
                                  DRMID(phys_enc->parent), intr_idx,
                                  irq->irq_idx,
                                  phys_enc->hw_pp->idx - PINGPONG_0,
  

@@ -315,8 +314,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc, ret = 0; } else { ret = -ETIMEDOUT;

•                   DRM_DEBUG_KMS("irq timeout id=%u, intr=%d, "
  

•                                 "irq=%d, pp=%d, atomic_cnt=%d",
  

•                   DRM_DEBUG_KMS("irq timeout id=%u, intr=%d, irq=%d, pp=%d, atomic_cnt=%d\n",
                                  DRMID(phys_enc->parent), intr_idx,
                                  irq->irq_idx,
                                  phys_enc->hw_pp->idx - PINGPONG_0,
  
  

base-commit: e9f1cbc0c4114880090c7a578117d3b9cf184ad4

https://chromeos.dev