Re: [PATCH v8 11/17] pwm: crc: Enable/disable PWM output on enable/disable

On Sun, Aug 30, 2020 at 02:57:47PM +0200, Hans de Goede wrote:

The pwm-crc code is using 2 different enable bits:

1. bit 7 of the PWM0_CLK_DIV (PWM_OUTPUT_ENABLE)
2. bit 0 of the BACKLIGHT_EN register

So far we've kept the PWM_OUTPUT_ENABLE bit set when disabling the PWM, this commit makes crc_pwm_disable() clear it on disable and makes crc_pwm_enable() set it again on re-enable.

Acked-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com Signed-off-by: Hans de Goede hdegoede@redhat.com

---

Changes in v3:

• Remove paragraph about tri-stating the output from the commit message, we don't have a datasheet so this was just an unfounded guess

---

drivers/pwm/pwm-crc.c | 4 ++++ 1 file changed, 4 insertions(+)

Acked-by: Thierry Reding thierry.reding@gmail.com