8 Jul
2020
8 Jul
'20
3:27 a.m.
On Wed, 2020-07-08 at 13:22 +1000, Ben Skeggs wrote:
On Wed, 8 Jul 2020 at 03:31, Gustavo A. R. Silva gustavoars@kernel.org wrote:
Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case.
I really like this! I was not a fan of explicitly marking those with comments.
Thank you, taken in my tree.
[]
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
[]
@@ -932,7 +932,7 @@ nv50_dp_bpc_to_depth(unsigned int bpc) switch (bpc) { case 6: return 0x2; case 8: return 0x5;
case 10: /* fall-through */
case 10: fallthrough;
IMO: this comment/fallthrough should be removed instead.