On Tue, Jul 21, 2015 at 04:40:08PM +0530, Malladi, Kausal wrote:
On Tuesday 21 July 2015 05:33 AM, Matt Roper wrote:
On Wed, Jul 15, 2015 at 06:39:35PM +0530, Kausal Malladi wrote:
...
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 11d491e..9e994fc 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -13773,6 +13773,9 @@ static void intel_begin_crtc_commit(struct drm_crtc *crtc) if (!needs_modeset(crtc->state) && INTEL_INFO(dev)->gen >= 9) skl_detach_scalers(intel_crtc);
- if (!needs_modeset(crtc->state))
intel_color_manager_crtc_commit(dev, crtc->state);It's not immediately clear to me why this is only for the '!needs_modeset' case. Does color management get setup somewhere else in cases where a display update does involve a modeset?
This is just an extra precaution. Do you think that we should remove it?
Kausal
It seems to me that if you updated your color settings in the process of also doing a full modeset, then those new settings wouldn't take effect until you followed up with another, non-modeset, pageflip. Unless I'm overlooking something that would cause them to be programmed on the first frame anyway?
Matt