Re: [PATCH v4 2/3] drm/loongson: Add GPIO and I2C driver for loongson drm.

Hi lichenyang,

On Fri, Jul 30, 2021 at 05:41:47PM +0800, lichenyang wrote:

Implement use GPIO and I2C driver to detect connector and fetch EDID via DDC.

v3:

• Change some driver log to the drm_ version.

v2:

• Optimize the error handling process.
• Delete loongson_i2c_bus_match and loongson_i2c_add function.
• Optimize part of the code flow.

Signed-off-by: lichenyang lichenyang@loongson.cn

I will return later with more detailed feedback.

One high-level comment is that all the i2c support would be much better modelled as a bridge. And then you could use the bridge_connector.

Sam