On Thu, Sep 7, 2017 at 6:12 PM, Noralf Trønnes noralf@tronnes.org wrote:
Den 07.09.2017 14.59, skrev Linus Walleij:
On Mon, Sep 4, 2017 at 9:43 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Fri, Sep 01, 2017 at 11:46:29AM +0200, Linus Walleij wrote:
If we cannot find a panel, assume that the output from the PL111 is connected directly to a "dumb" VGA connector, so look up the connector from that bridge.
Signed-off-by: Linus Walleij linus.walleij@linaro.org if (panel) { priv->panel = panel; priv->connector = panel->connector;
} else {priv->connector = drm_dumb_vga_get_connector(bridge);Why do you need to set this?
Essentially because drm_simple_display_pipe_init() require that you specify a connector in the last argument, so I have to get it from somewhere.
It's optional particularly for the bridge case. From docs:
- If a connector is supplied, the pipe will be coupled with the provided
- connector. You may supply a NULL connector when using drm bridges, that
- handle connectors themselves (see
drm_simple_display_pipe_attach_bridge()).
Yup, this was the flip side of the work to make bridges useful for the simple pipe helpers. The other one is the helper to set up the bridge I mentioned earlier in this thread. -Daniel