On Thu, Feb 27, 2020 at 03:02:18PM +0300, Wambui Karuga wrote:
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails, and should return void. Therefore, remove its use as a return value in hdlcd_debugfs_init and have the latter function return void.
Signed-off-by: Wambui Karuga wambui.karugax@gmail.com
Acked-by: Liviu Dudau liviu.dudau@arm.com
Not sure how you're going to address Greg KH's comment (maybe one single patch that converts debugfs_init to void *and* changes the signature to all hooks?) but I'm going to assume that you will get the whole series merged in one go so I don't have to push this individual patch into HDLCD tree.
Best regards, Liviu
drivers/gpu/drm/arm/hdlcd_drv.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c index 2e053815b54a..194419f47c5e 100644 --- a/drivers/gpu/drm/arm/hdlcd_drv.c +++ b/drivers/gpu/drm/arm/hdlcd_drv.c @@ -224,10 +224,11 @@ static struct drm_info_list hdlcd_debugfs_list[] = { { "clocks", hdlcd_show_pxlclock, 0 }, };
-static int hdlcd_debugfs_init(struct drm_minor *minor) +static void hdlcd_debugfs_init(struct drm_minor *minor) {
- return drm_debugfs_create_files(hdlcd_debugfs_list,
ARRAY_SIZE(hdlcd_debugfs_list), minor->debugfs_root, minor);
- drm_debugfs_create_files(hdlcd_debugfs_list,
ARRAY_SIZE(hdlcd_debugfs_list),minor->debugfs_root, minor);} #endif
-- 2.25.0