Re: [PATCH] drm: Don't pass negative delta to ktime_sub_ns()

vimOn Mit, 2013-07-17 at 12:58 +0100, Chris Wilson wrote:

On Wed, Jun 12, 2013 at 11:58:44AM +0200, Michel Dänzer wrote:

...

From: Michel Dänzer michel.daenzer@amd.com

It takes an unsigned value. This happens not to blow up on 64-bit architectures, but it does on 32-bit, causing drm_calc_vbltimestamp_from_scanoutpos() to calculate totally bogus timestamps for vblank events. Which in turn causes e.g. gnome-shell to hang after a DPMS off cycle with current xf86-video-ati Git.

Cc: stable@vger.kernel.org Signed-off-by: Michel Dänzer michel.daenzer@amd.com

Dave, it looks like you missed this patch.

Dave, any particular reason why this fix still isn't merged? It's approaching its two-month anniversary...