Re: [PATCH 1/6] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

On Fri, Jan 07, 2022 at 03:55:10PM +0100, Neil Armstrong wrote:

The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on the same Amlogic SoCs.

Signed-off-by: Neil Armstrong narmstrong@baylibre.com

.../display/amlogic,meson-dw-mipi-dsi.yaml | 118 ++++++++++++++++++ 1 file changed, 118 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml

diff --git a/Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml new file mode 100644 index 000000000000..f3070783d606 --- /dev/null +++ b/Documentation/devicetree/bindings/display/amlogic,meson-dw-mipi-dsi.yaml @@ -0,0 +1,118 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2020 BayLibre, SAS +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/amlogic,meson-dw-mipi-dsi.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

+title: Amlogic specific extensions to the Synopsys Designware MIPI DSI Host Controller

+maintainers:

• • Neil Armstrong narmstrong@baylibre.com

+description: |

• The Amlogic Meson Synopsys Designware Integration is composed of
• • A Synopsys DesignWare MIPI DSI Host Controller IP
• • A TOP control block controlling the Clocks & Resets of the IP

+allOf:

• • $ref: dsi-controller.yaml#

+properties:

• compatible:
• enum:

•  - amlogic,meson-g12a-dw-mipi-dsi
  

• reg:
• maxItems: 1
• clocks:
• minItems: 2
• clock-names:
• minItems: 2
• items:

•  - const: pclk
  

•  - const: px_clk
  

•  - const: meas_clk
  

• resets:
• minItems: 1
• reset-names:
• items:

•  - const: top
  

• phys:
• minItems: 1
• phy-names:
• items:

•  - const: dphy
  

• ports:
• $ref: /schemas/graph.yaml#/properties/ports
• properties:

•  port@0:
  

•    $ref: /schemas/graph.yaml#/$defs/port-base
  

/schemas/graph.yaml#/properties/port

•    unevaluatedProperties: false
  

And this can be dropped.

•    description: Input node to receive pixel data.
  

•  port@1:
  

•    $ref: /schemas/graph.yaml#/$defs/port-base
  

•    unevaluatedProperties: false
  

Same here.

With that,

Reviewed-by: Rob Herring robh@kernel.org

•    description: DSI output node to panel.
  

• required:

•  - port@0
  

•  - port@1
  

+required:

• • compatible
• • reg
• • clocks
• • clock-names
• • resets
• • reset-names
• • phys
• • phy-names
• • ports

+unevaluatedProperties: false

+examples:

• • |
• dsi@7000 {

•      compatible = "amlogic,meson-g12a-dw-mipi-dsi";
  

•      reg = <0x6000 0x400>;
  

•      resets = <&reset_top>;
  

•      reset-names = "top";
  

•      clocks = <&clk_pclk>, <&clk_px>;
  

•      clock-names = "pclk", "px_clk";
  

•      phys = <&mipi_dphy>;
  

•      phy-names = "dphy";
  

•      ports {
  

•          #address-cells = <1>;
  

•          #size-cells = <0>;
  

•          /* VPU VENC Input */
  

•          mipi_dsi_venc_port: port@0 {
  

•              reg = <0>;
  

•              mipi_dsi_in: endpoint {
  

•                   remote-endpoint = <&dpi_out>;
  

•              };
  

•          };
  

•          /* DSI Output */
  

•          mipi_dsi_panel_port: port@1 {
  

•              reg = <1>;
  

•              mipi_out_panel: endpoint {
  

•                  remote-endpoint = <&mipi_in_panel>;
  

•              };
  

•          };
  

•      };
  

• };

-- 2.25.1