Re: [PATCH] drivers: fbtft: Refactor backlight logic

On Sat, Feb 12, 2022 at 12:27:39PM +0800, qianfanguijin@163.com wrote:

From: qianfan Zhao qianfanguijin@163.com

Control led gpios by using GPIO_ACTIVE flags, don't detect the polarity by reading the gpio value when probe.

...

• enum gpiod_flags flags = GPIOD_OUT_HIGH;
• /* request and turn on backlight */
• return fbtft_request_one_gpio_with_flags(par, name, index, flags, gpiop);

But taking into consideration all possible polarities this is wrong assumption. Depending on the flags in DT or ACPI this may give an opposite effect.

P.S. Please, Cc all your fbtft patches to fbdev maintainer as well.