On Sun, 21 Nov 2021, Hans de Goede hdegoede@redhat.com wrote:
After the recent refactoring of the backlight code the contents of intel_panel_actually_set_backlight() is exactly the same (minus a small wording difference in the drm_dbg_kms() as the contents if the more widely used intel_backlight_set_pwm_level() function.
Drop the duplicate intel_panel_actually_set_backlight() function.
Signed-off-by: Hans de Goede hdegoede@redhat.com
Reviewed-by: Jani Nikula jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_backlight.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c index 9523411cddd8..03cd730c926a 100644 --- a/drivers/gpu/drm/i915/display/intel_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_backlight.c @@ -268,18 +268,6 @@ static void ext_pwm_set_backlight(const struct drm_connector_state *conn_state, pwm_apply_state(panel->backlight.pwm, &panel->backlight.pwm_state); }
-static void -intel_panel_actually_set_backlight(const struct drm_connector_state *conn_state, u32 level) -{
- struct intel_connector *connector = to_intel_connector(conn_state->connector);
- struct drm_i915_private *i915 = to_i915(connector->base.dev);
- struct intel_panel *panel = &connector->panel;
- drm_dbg_kms(&i915->drm, "set backlight level = %d\n", level);
- panel->backlight.funcs->set(conn_state, level);
-}
/* set backlight brightness to level in range [0..max], assuming hw min is
- respected.
*/ @@ -314,7 +302,7 @@ void intel_backlight_set_acpi(const struct drm_connector_state *conn_state, panel->backlight.device->props.max_brightness);
if (panel->backlight.enabled)
intel_panel_actually_set_backlight(conn_state, hw_level);
intel_backlight_set_pwm_level(conn_state, hw_level);mutex_unlock(&dev_priv->backlight_lock);
} @@ -863,7 +851,7 @@ static void intel_panel_set_backlight(const struct drm_connector_state *conn_sta panel->backlight.level = hw_level;
if (panel->backlight.enabled)
intel_panel_actually_set_backlight(conn_state, hw_level);
intel_backlight_set_pwm_level(conn_state, hw_level);mutex_unlock(&dev_priv->backlight_lock);
}