Re: [PATCH v4 56/78] drm/vc4: hdmi: Store the encoder type in the variant structure

Hi Maxime

On Wed, 8 Jul 2020 at 18:43, Maxime Ripard maxime@cerno.tech wrote:

The vc4 CRTC will use the encoder type to control its output clock muxing. However, this will be different from HDMI0 to HDMI1, so let's store our type in the variant structure so that we can support multiple controllers later on.

Signed-off-by: Maxime Ripard maxime@cerno.tech

Reviewed-by: Dave Stevenson dave.stevenson@raspberrypi.com

---

drivers/gpu/drm/vc4/vc4_hdmi.c | 3 ++- drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index a50220bfd5dd..c50241170d7e 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -1268,7 +1268,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)

    dev_set_drvdata(dev, vc4_hdmi);
    encoder = &vc4_hdmi->encoder.base.base;

•   vc4_hdmi->encoder.base.type = VC4_ENCODER_TYPE_HDMI0;
  

•   vc4_hdmi->encoder.base.type = variant->encoder_type;
    vc4_hdmi->pdev = pdev;
    vc4_hdmi->variant = variant;
  
  

@@ -1447,6 +1447,7 @@ static int vc4_hdmi_dev_remove(struct platform_device *pdev) }

static const struct vc4_hdmi_variant bcm2835_variant = {

•   .encoder_type           = VC4_ENCODER_TYPE_HDMI0,
    .registers              = vc4_hdmi_fields,
    .num_registers          = ARRAY_SIZE(vc4_hdmi_fields),
  
  

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.h b/drivers/gpu/drm/vc4/vc4_hdmi.h index 0c32dc46d289..0d529db4b3ab 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.h +++ b/drivers/gpu/drm/vc4/vc4_hdmi.h @@ -27,6 +27,9 @@ struct vc4_hdmi; struct vc4_hdmi_register;

struct vc4_hdmi_variant {

•   /* Encoder Type for that controller */
  

•   enum vc4_encoder_type encoder_type;
  

•   /* List of the registers available on that variant */
    const struct vc4_hdmi_register *registers;
  
  

-- git-series 0.9.1