Re: [PATCH v1 1/6] dt-bindings: mediatek,dpi: Add mt8195 dpintf

Hi Markus,

On Mon, Sep 06, 2021 at 09:35:24PM +0200, Markus Schneider-Pargmann wrote:

DP_INTF is similar to the actual dpi. They differ in some points regarding registers and what needs to be set but the function blocks itself are similar in design.

Signed-off-by: Markus Schneider-Pargmann msp@baylibre.com

I fail to see why they share the same dt-schema as the main content in the schema is the clocks and they differ.

A new mediatek,dpintf schema seems more appropriate.

I recall I though so when reading the RFC variant but failed to comment on it.

Sam

---

.../display/mediatek/mediatek,dpi.yaml | 43 ++++++++++++++++--- 1 file changed, 37 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index dd2896a40ff0..1a158b719ce6 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml#

-title: mediatek DPI Controller Device Tree Bindings +title: mediatek DPI/DP_INTF Controller Device Tree Bindings

maintainers:

• CK Hu ck.hu@mediatek.com

@@ -13,7 +13,8 @@ maintainers: description: | The Mediatek DPI function block is a sink of the display subsystem and provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel

• output bus.

• output bus. The Mediatek DP_INTF is a similar function block that is
• connected to the (embedded) display port function block.

properties: compatible: @@ -23,6 +24,7 @@ properties: - mediatek,mt8173-dpi - mediatek,mt8183-dpi - mediatek,mt8192-dpi

•  - mediatek,mt8195-dpintf
  
  

  reg: maxItems: 1

@@ -37,10 +39,11 @@ properties: - description: DPI PLL

clock-names:

• items:

•  - const: pixel
  

•  - const: engine
  

•  - const: pll
  

• description:

•  For dpi clocks pixel, engine and pll are required. For dpintf pixel,
  

•  hf_fmm and hf_fdp are required.
  

• minItems: 3

• maxItems: 3

  pinctrl-0: true pinctrl-1: true

@@ -64,6 +67,34 @@ required:

• clock-names
• port

+allOf:

• • if:

•  properties:
  

•    compatible:
  

•      contains:
  

•        enum:
  

•          - mediatek,mt8195-dpintf
  

• then:

•  properties:
  

•    clocks:
  

•      minItems: 3
  

•      maxItems: 3
  

•    clock-names:
  

•      items:
  

•        - const: pixel
  

•        - const: hf_fmm
  

•        - const: hf_fdp
  

• else:

•  properties:
  

•    clocks:
  

•      minItems: 3
  

•      maxItems: 3
  

•    clock-names:
  

•      items:
  

•        - const: pixel
  

•        - const: engine
  

•        - const: pll
  

additionalProperties: false

examples:

2.33.0