On Fri, 03 May 2013, Daniel Vetter daniel@ffwll.ch wrote:
On Fri, May 03, 2013 at 11:17:42AM +0200, dl9pf@gmx.de wrote:
From: Jan-Simon Möller dl9pf@gmx.de
Description: intel_gmbus_is_forced_bit is no extern as its body is right below. Likewise for intel_gmbus_is_port_valid.
This fixes a compilation issue with clang. An initial version of this patch was developed by PaX Team <pageexec at freemail.hu>. This is respin of this patch.
Signed-off-by: Jan-Simon Möller dl9pf@gmx.de CC: pageexec@freemail.hu CC: daniel.vetter@ffwll.ch CC: airlied@linux.ie CC: intel-gfx@lists.freedesktop.org CC: dri-devel@lists.freedesktop.org CC: linux-kernel@vger.kernel.org
Picked up for -fixes, thanks for the patch.
Please drop it.
The patch removes the inline keyword, creating dozens of copies of the functions, and consequently loads of warnings:
drivers/gpu/drm/i915/i915_drv.h:1803:13: warning: ‘intel_gmbus_is_port_valid’ defined but not used [-Wunused-function] drivers/gpu/drm/i915/i915_drv.h:1812:13: warning: ‘intel_gmbus_is_forced_bit’ defined but not used [-Wunused-function]
BR, Jani.