Re: [RFC v2 PATCH v2 06/14] drm/exynos: support MIPI DSI command mode

On Mon, Apr 21, 2014 at 09:28:33PM +0900, YoungJun Cho wrote: [...]

diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 7209df1..244d197 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -49,6 +49,7 @@ struct mipi_dsi_msg {

• @detach: detach DSI device from DSI host
• @transfer: send and/or receive DSI packet, return number of received bytes,

•      or error
  

• • @te_handler: call CRTC TE handler callback from DSI host

Perhaps you can explain some more what this means or why it would be necessary.

diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index c2ab77a..0ad64ed 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -46,6 +46,13 @@ struct drm_panel { struct list_head list; };

+struct drm_panel_cpu_timings {

• unsigned int cs_setup;
• unsigned int wr_setup;
• unsigned int wr_act;
• unsigned int wr_hold;

+};

Similarily here. What's this?

Thierry