Re: [PATCH 2/2] mm: remove get_user_pages_locked()

On 31/10/2016 11:02, Lorenzo Stoakes wrote:

• • get_user_pages should be phased out in favor of
• • get_user_pages_locked|unlocked or get_user_pages_fast. Nothing
• • should use get_user_pages because it cannot pass
• • FAULT_FLAG_ALLOW_RETRY to handle_mm_fault.

This comment should be preserved in some way. In addition, removing get_user_pages_locked() makes it harder (compared to a simple "git grep -w") to identify callers that lack allow-retry functionality). So I'm not sure about the benefits of these patches.

If all callers were changed, then sure removing the _locked suffix would be a good idea.

Paolo