On Fri, 21 Jan 2011 00:43:59 +0000 Matthew Garrett mjg59@srcf.ucam.org wrote:
On Thu, Jan 20, 2011 at 03:13:49PM -0800, Andrew Morton wrote:
On Fri, 21 Jan 2011 00:43:46 +0330 Ali Gholami Rudi aliqrudi@gmail.com wrote:
Ali Gholami Rudi aliqrudi@gmail.com wrote:
I tried to apply this patch but I get:
drivers/gpu/drm/i915/intel_panel.c: In function 'intel_panel_setup_backlight': drivers/gpu/drm/i915/intel_panel.c:319: error: 'struct backlight_properties' has no member named 'type' drivers/gpu/drm/i915/intel_panel.c:319: error: 'BACKLIGHT_RAW' undeclared (first use in this function) drivers/gpu/drm/i915/intel_panel.c:319: error: (Each undeclared identifier is reported only once drivers/gpu/drm/i915/intel_panel.c:319: error: for each function it appears in.)
After applying patch 1/5, the patch applied cleanly. Now I can change the brightness using /sys/class/backlight/intel_backlight/brightness. So it does fix my issue.
So we have a patch ordering issue and the radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch build error.
He applied 2/5, it didn't build, he applied 1/5 and it built? I don't think that's a patch ordering issue :)
What, you expect reading skills?
I think Michel's patch should fix the Radeon one. If not, can you drop that and keep the rest of the set? I'm travelling at the moment and won't have proper build access until the weekend.
OK, I resurrected everything.
I updated the new drivers/video/backlight/adp5520_bl.c, but there's a decent chance that unconverted drivers will sneak in. I trust they will still work OK?