Hi Jingoo,
在 2015/8/6 22:19, Jingoo Han 写道:
On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote:
In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next bridge of dp bridge.
Signed-off-by: Yakir Yang ykk@rock-chips.com
drivers/gpu/drm/exynos/exynos_dp_core.c | 196 ++++++++++++++++++++------------ drivers/gpu/drm/exynos/exynos_dp_core.h | 2 + 2 files changed, 126 insertions(+), 72 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index a8097a4..aa99e23 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -3,6 +3,7 @@
- Copyright (C) 2012 Samsung Electronics Co., Ltd.
- Author: Jingoo Han jg1.han@samsung.com
Yakir Yang <ykk@rock-chips.com>
Please don't add this. You just fixed some parts of this code. I don't find the reason why you have to be added to author for this file. If you want the title for an author, please send the patch for a new IP, instead of modifying the exiting codes.
Okay, thanks for your remind ;)
[...] MODULE_AUTHOR("Jingoo Han jg1.han@samsung.com"); +MODULE_AUTHOR("Yakir Yang ykk@rock-chips.com");
The same as above.
Done
MODULE_DESCRIPTION("Samsung SoC DP Driver"); MODULE_LICENSE("GPL v2"); diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.h b/drivers/gpu/drm/exynos/exynos_dp_core.h index c321ad5..f2584b8 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.h +++ b/drivers/gpu/drm/exynos/exynos_dp_core.h @@ -3,6 +3,7 @@
- Copyright (C) 2012 Samsung Electronics Co., Ltd.
- Author: Jingoo Han jg1.han@samsung.com
Yakir Yang <ykk@rock-chips.com>
The same as above. Here, you just added 1 line. If we add someone to author in this way, a lot of people should be added to author.
Done
- Yakir
Best regards, Jingoo Han