Re: [PATCH] drm/msm/dp: Add "qcom, sc7280-dp" to support display port.

Quoting Kuogee Hsieh (2021-12-03 14:02:39)

Signed-off-by: Kuogee Hsieh quic_khsieh@quicinc.com

drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+)

One nit

Reviewed-by: Stephen Boyd swboyd@chromium.org

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index d44f18b..91582d3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -146,6 +146,7 @@ static const struct msm_dp_config sc7280_dp_cfg = { static const struct of_device_id dp_dt_match[] = { { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },

•   { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
  

The letter d comes before e so it would be better to sort this alphanumerically and avoid conflicts later.