Hi Jacopo,
On Mon, Aug 26, 2019 at 9:58 AM Jacopo Mondi jacopo@jmondi.org wrote:
On Mon, Aug 26, 2019 at 09:34:41AM +0200, Geert Uytterhoeven wrote:
On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi jacopo+renesas@jmondi.org wrote:
Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module.
CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).
Signed-off-by: Jacopo Mondi jacopo+renesas@jmondi.org
Thanks for your patch!
--- /dev/null +++ b/Documentation/devicetree/bindings/display/renesas,cmm.txt @@ -0,0 +1,33 @@ +* Renesas R-Car Color Management Module (CMM)
+Renesas R-Car image enhancement module connected to R-Car DU video channels.
+Required properties:
- compatible: shall be one or more of the following:
- "renesas,cmm-r8a7795": for R8A7795 (R-Car H3) compatible CMM.
- "renesas,cmm-r8a7796": for R8A7796 (R-Car M3-W) compatible CMM.
- "renesas,cmm-r8a77965": for R8A77965 (R-Car M3-N) compatible CMM.
- "renesas,cmm-r8a77990": for R8A77990 (R-Car E3) compatible CMM.
- "renesas,cmm-r8a77995": for R8A77995 (R-Car D3) compatible CMM.
Please use "renesas,<socype->-cmm" instead of "renesas,cmm-<soctype>".
I actually copied it from the r-car gpio bindings, and I liked cmm-<soctype> better. If you prefer I can change it though.
We switched from "renesas,cmm-<soctype>" to "renesas,<socype->-cmm" a few years ago, upon request from the DT people:
vendor -> family/SoC -> IP core
Unfortunately we cannot change the old style in existing bindings, without great effort and backwards compatibility ramifications.
Gr{oetje,eeting}s,
Geert