RE: [PATCH rdma-core 2/5] mlx5: Support dma-buf based memory region

-----Original Message----- From: Jason Gunthorpe jgg@ziepe.ca Sent: Monday, November 23, 2020 10:02 AM To: Xiong, Jianxin jianxin.xiong@intel.com Cc: linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford dledford@redhat.com; Leon Romanovsky leon@kernel.org; Sumit Semwal sumit.semwal@linaro.org; Christian Koenig christian.koenig@amd.com; Vetter, Daniel daniel.vetter@intel.com Subject: Re: [PATCH rdma-core 2/5] mlx5: Support dma-buf based memory region

On Mon, Nov 23, 2020 at 09:53:01AM -0800, Jianxin Xiong wrote:

...

+struct ibv_mr *mlx5_reg_dmabuf_mr(struct ibv_pd *pd, uint64_t offset, size_t length,

• 		  uint64_t iova, int fd, int acc) {
  

• struct mlx5_mr *mr;
• int ret;
• enum ibv_access_flags access = (enum ibv_access_flags)acc;

Why?

It's copied from mlx5_reg_mr(). Didn't pay attention to this but looks unnecessary now.

Jason