Re: [PATCH 03/12] drm/i915: Attach color properties to CRTC

On Wed, Jul 01, 2015 at 09:18:13PM +0530, Kausal Malladi wrote:

From: Kausal Malladi Kausal.Malladi@intel.com

This patch does the following:

1. Adds new files intel_color_manager(.c/.h)
2. Attaches color properties to CRTC while initialization

We usually order the series so that "it always works". In this case, you are attaching the properties to the CRTC before having any code to handle them, so if we are bisecting the tree and end up in the middle of the series we get a broken behaviour.

If you put the attach() at the end of the series, we'll only expose the properties when we do have to handle them.