Found-By: Coccinelle Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c | 10 +++++----- drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c | 4 ++-- drivers/gpu/drm/amd/dal/dc/calcs/scaler_filter.c | 4 ++-- drivers/gpu/drm/amd/dal/dc/gpio/gpio_service.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c b/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c index 32b69d8..b51aee2 100644 --- a/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c +++ b/drivers/gpu/drm/amd/dal/amdgpu_dm/amdgpu_dm_types.c @@ -825,11 +825,11 @@ static void copy_crtc_timing_for_drm_display_mode( dst_mode->crtc_hsync_end = src_mode->crtc_hsync_end; dst_mode->crtc_htotal = src_mode->crtc_htotal; dst_mode->crtc_hskew = src_mode->crtc_hskew; - dst_mode->crtc_vblank_start = src_mode->crtc_vblank_start;; - dst_mode->crtc_vblank_end = src_mode->crtc_vblank_end;; - dst_mode->crtc_vsync_start = src_mode->crtc_vsync_start;; - dst_mode->crtc_vsync_end = src_mode->crtc_vsync_end;; - dst_mode->crtc_vtotal = src_mode->crtc_vtotal;; + dst_mode->crtc_vblank_start = src_mode->crtc_vblank_start; + dst_mode->crtc_vblank_end = src_mode->crtc_vblank_end; + dst_mode->crtc_vsync_start = src_mode->crtc_vsync_start; + dst_mode->crtc_vsync_end = src_mode->crtc_vsync_end; + dst_mode->crtc_vtotal = src_mode->crtc_vtotal; }
static void decide_crtc_timing_for_drm_display_mode( diff --git a/drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c index cecb30e..d9b7b82 100644 --- a/drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c +++ b/drivers/gpu/drm/amd/dal/dc/bios/bios_parser.c @@ -2174,7 +2174,7 @@ enum bp_result dc_bios_get_din_connector_info(struct dc_bios *dcb,
object = get_bios_object(bp, id); if (!object) { - BREAK_TO_DEBUGGER(); /* Invalid object id */; + BREAK_TO_DEBUGGER(); /* Invalid object id */ return BP_RESULT_BADINPUT; }
@@ -3349,7 +3349,7 @@ static uint32_t get_support_mask_for_device_id(struct device_id device_id) break; default: break; - }; + }
/* Unidentified device ID, return empty support mask. */ return 0; diff --git a/drivers/gpu/drm/amd/dal/dc/calcs/scaler_filter.c b/drivers/gpu/drm/amd/dal/dc/calcs/scaler_filter.c index 706bf0a..e224577 100644 --- a/drivers/gpu/drm/amd/dal/dc/calcs/scaler_filter.c +++ b/drivers/gpu/drm/amd/dal/dc/calcs/scaler_filter.c @@ -1181,12 +1181,12 @@ static void destroy_3d_storage( dm_free(tables[indexof_table][indexof_row]);
++indexof_row; - }; + }
dm_free(tables[indexof_table]);
++indexof_table; - }; + }
dm_free(tables);
diff --git a/drivers/gpu/drm/amd/dal/dc/gpio/gpio_service.c b/drivers/gpu/drm/amd/dal/dc/gpio/gpio_service.c index 8b4eba9..7aa528b 100644 --- a/drivers/gpu/drm/amd/dal/dc/gpio/gpio_service.c +++ b/drivers/gpu/drm/amd/dal/dc/gpio/gpio_service.c @@ -140,7 +140,7 @@ failure_2:
if (slot) dm_free(slot); - }; + }
failure_1: dm_free(service);