Re: [PATCH 2/6] drm: Add drm_simple_encoder_{init,create}()

+static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = {

• .destroy = drm_encoder_cleanup,

+};

+/**

• • drm_simple_encoder_init - Init a preallocated encoder
• • @dev: drm device
• • @funcs: callbacks for this encoder
• • @encoder_type: user visible type of the encoder
• • @name: printf style format string for the encoder name, or NULL

• •    for default name
    

• • Initialises a preallocated encoder that has no further functionality. The
• • encoder will be released automatically.
• • Returns:
• • Zero on success, error code on failure.
• */

+int drm_simple_encoder_init(struct drm_device *dev,

• 	    struct drm_encoder *encoder,
  

• 	    int encoder_type, const char *name, ...)
  

How about using

#define drm_simple_encoder_init(dev, type, name, ...) \ drm_encoder_init(dev, drm_simple_encoder_funcs_cleanup, type, name, __VA_ARGS__)

instead ?

cheers, Gerd