On Mon, Nov 03, 2014 at 12:10:29PM -0500, Sean Paul wrote:
On Mon, Nov 3, 2014 at 4:13 AM, Thierry Reding thierry.reding@gmail.com wrote:
From: Thierry Reding treding@nvidia.com
Provide small convenience wrappers to query or set the pixel format used by the interface.
Signed-off-by: Thierry Reding treding@nvidia.com
drivers/gpu/drm/drm_mipi_dsi.c | 42 ++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index da34469b9b98..226822a44457 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -553,6 +553,27 @@ int mipi_dsi_dcs_get_power_mode(struct mipi_dsi_device *dsi, u8 *mode) EXPORT_SYMBOL(mipi_dsi_dcs_get_power_mode);
/**
- mipi_dsi_dcs_get_pixel_format() - gets the pixel format for the RGB image
- data used by the interface
- @dsi: DSI peripheral device
- @format: return location for the pixel format
- Return: 0 on success or a negative error code on failure.
- */
+int mipi_dsi_dcs_get_pixel_format(struct mipi_dsi_device *dsi, u8 *format) +{
ssize_t err;err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_PIXEL_FORMAT, format,sizeof(*format));if (err < 0)return err;This should probably return -ENODATA when err != sizeof(*format), like the previous patch did.
Done.
It might be worth moving that logic into mipi_dsi_dcs_read, assuming we're not interested in partial data.
Agreed. I think we can leave that for a subsequent refactoring once these function have matured a bit more and patterns appear.
Thierry