On Tue, 28 Jul 2020 at 17:30, Christian König christian.koenig@amd.com wrote:
Am 28.07.20 um 08:24 schrieb Dave Airlie:
From: Dave Airlie airlied@redhat.com
The WARN_ON in the non-underscore path is off questionable value (can we drop it from the non-slowpath?). At least for nouveau where it's just looked up the gem object we know the ttm object has a reference always so we can skip the check.
Yeah, agreed. Wanted to look into removing that for quite some time as well.
It's probably nouveau could use execbut utils here at some point but for now align the code between them to always call the __ versions, and remove the non underscored version.
Can we do it the other way around and remove all uses of the __ versions of the functions instead and then merge the __ version into the normal one without the WARN_ON()?
Yes sounds like a plan, I just wasn't sure the WARN_ON had value, bit since you agree is dubious at best, I'm happy to rip it out.
Will send a v2 tomorrow.
Dave.