Re: [Intel-gfx] [PATCH 7/8] drm/irq: Implement a generic vblank_wait function

On 31.07.2014 16:54, Daniel Vetter wrote:

On Thu, Jul 31, 2014 at 3:14 AM, Michel Dänzer michel@daenzer.net wrote:

...

I think it would be better to refactor drm_wait_vblank() than to reinvent it.

That's the ioctl implementation which spends most of its time decoding ioctl structures. If we take that out then there's about half a line which would be shared (since a lot of the stuff in there is ums gunk that we don't want to carry over to a kms-only internal interface). So imo that doesn't make sense.

I'm referring to the core logic of waiting for a number of vblank periods or until the vblank period with a given sequence number, dealing with wraparound etc. The issues you guys were discussing for a new function were ironed out there long ago.