Re: [PATCH 1/3] drm/omap: fix uninitialized ret variable

On 29/03/18 13:58, Emil Velikov wrote:

On 29 March 2018 at 11:40, Tomi Valkeinen tomi.valkeinen@ti.com wrote:

...

audio_config function for both HDMI4 and HDMI5 return uninitialized value as the error code if the display is not currently enabled. For some reason this has not caused any issues.

Doubt many people try hdmi audio with disabled display ;-)

I think it can happen if the display is connected but blanked.

Reviewed-by: Emil Velikov emil.velikov@collabora.com

Thanks for the review!

Tomi