Re: [PATCH v5 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support

Hi Laurent,

[...]

...

+static const struct display_timing satoz_sat050at40h12r2_timing = {

• .pixelclock = {33300000, 33300000, 50000000},
• .hactive = {800, 800, 800},
• .hfront_porch = {16, 210, 354},
• .hback_porch = {46, 46, 46},
• .hsync_len = {1, 1, 40},
• .vactive = {480, 480, 480},
• .vfront_porch = {7, 22, 147},
• .vback_porch = {23, 23, 23},
• .vsync_len = {1, 1, 20},

+};

+static const struct panel_desc satoz_sat050at40h12r2 = {

• .timings = &satoz_sat050at40h12r2_timing,
• .num_timings = 1,
• .bpc = 8,
• .size = {

• .width = 108,
  

• .height = 65,
  

• },
• .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
• .connector_type = DRM_MODE_CONNECTOR_LVDS,

I'm trying to fix inconsistencies in the panel-simple driver, and this caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA should be used instead. As I couldn't find documentation for the panel, I can't tell which format is correct. Could you please help ?

Indeed, I got this datasheet under NDA.

We checked with Paul, we think the right format is: MEDIA_BUS_FMT_RGB888_1X7X4_SPWG.

Thanks, Miquèl