On Mon, 31 Jan 2022 at 17:55, Hsin-Yi Wang hsinyi@chromium.org wrote:
On Tue, Feb 1, 2022 at 12:37 AM Robert Foss robert.foss@linaro.org wrote:
On Thu, 20 Jan 2022 at 16:25, AngeloGioacchino Del Regno angelogioacchino.delregno@collabora.com wrote:
Il 14/01/22 10:14, allen ha scritto:
This adds support for the iTE IT6505. This device can convert DPI signal to DP output.
From: Allen Chen allen.chen@ite.com.tw Tested-by: Hsin-yi Wang hsinyi@chromium.org Signed-off-by: Hermes Wu hermes.wu@ite.com.tw Signed-off-by: Allen Chen allen.chen@ite.com.tw
v10 -> v11 : remove drm_bridge_new_crtc_state
drivers/gpu/drm/bridge/Kconfig | 8 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/ite-it6505.c | 3352 +++++++++++++++++++++++++++ 3 files changed, 3361 insertions(+) create mode 100644 drivers/gpu/drm/bridge/ite-it6505.c
...snip...
+static const struct of_device_id it6505_of_match[] = {
{ .compatible = "ite,it6505" },{ }+};
If you want to have a DT compatible and DT properties, you have to also add dt-bindings (yaml) for this driver, otherwise, any SoC/device DT will fail the dt binding check.... So, please, add that.
Let me second this. A dt-binding is needed for this driver to be complete, it functions as both documentation and a way to test the DTS that use this device, so it is really important.
The binding seems to be accepted before the driver: https://elixir.bootlin.com/linux/v5.16.4/source/Documentation/devicetree/bin...
I completely missed that. In that case we're only missing the reviewed-by tag from someone.
For the driver by itself, though:
Acked-by: AngeloGioacchino Del Regno angelogioacchino.delregno@collabora.com
+static struct i2c_driver it6505_i2c_driver = {
.driver = {.name = "it6505",.of_match_table = it6505_of_match,.pm = &it6505_bridge_pm_ops,},.probe = it6505_i2c_probe,.remove = it6505_i2c_remove,.shutdown = it6505_shutdown,.id_table = it6505_id,+};
+module_i2c_driver(it6505_i2c_driver);
+MODULE_AUTHOR("Allen Chen allen.chen@ite.com.tw"); +MODULE_DESCRIPTION("IT6505 DisplayPort Transmitter driver"); +MODULE_LICENSE("GPL v2");