On 07/02/2022 18:35, Maxime Ripard wrote:
The omap KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Full Range, respectively.
Since the initial value wasn't carried over in the state, the driver had to set it again in omap_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore.
Cc: Tomi Valkeinen tomba@kernel.org Signed-off-by: Maxime Ripard maxime@cerno.tech
drivers/gpu/drm/omapdrm/omap_plane.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c index d96bc929072a..b83d91ec030a 100644 --- a/drivers/gpu/drm/omapdrm/omap_plane.c +++ b/drivers/gpu/drm/omapdrm/omap_plane.c @@ -403,7 +403,6 @@ void omap_plane_install_properties(struct drm_plane *plane,
static void omap_plane_reset(struct drm_plane *plane) {
struct omap_plane *omap_plane = to_omap_plane(plane); struct omap_plane_state *omap_state;
if (plane->state)
@@ -414,8 +413,6 @@ static void omap_plane_reset(struct drm_plane *plane) return;
__drm_atomic_helper_plane_reset(plane, &omap_state->base);
plane->state->color_encoding = DRM_COLOR_YCBCR_BT601;
plane->state->color_range = DRM_COLOR_YCBCR_FULL_RANGE; }
static struct drm_plane_state *
Reviewed-by: Tomi Valkeinen tomi.valkeinen@ideasonboard.com
Tomi